Re: [PATCH v2] fix stack memory content leak via UNAME26

From: Kees Cook
Date: Wed Oct 10 2012 - 20:39:19 EST


On Wed, Oct 10, 2012 at 4:44 PM, Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, 10 Oct 2012 16:36:44 -0700
> Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
>> > would suffice?
>> >
>> > Not a big deal I guess, but copying out stuff beyond the NUL is a bit odd.
>>
>> Sure, that looks good to me.
>
> I think I'll stick with your tested patch for now. Could you please
> add "clean that up" to your todo list?

Sure. I've sent a v3 now. It still needed to handle the (theoretical)
len == 0 case, though.

-Kees

--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/