Re: [PATCH v4 1/3] devfreq: Core updates to support devices which can idle

From: Rafael J. Wysocki
Date: Wed Oct 10 2012 - 19:05:23 EST


On Wednesday 10 of October 2012 12:49:33 Rajagopal Venkat wrote:
> On 8 October 2012 13:44, MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx> wrote:
> >> Prepare devfreq core framework to support devices which
> >> can idle. When device idleness is detected perhaps through
> >> runtime-pm, need some mechanism to suspend devfreq load
> >> monitoring and resume back when device is online. Present
> >> code continues monitoring unless device is removed from
> >> devfreq core.
> >>
> >> This patch introduces following design changes,
> >>
> >> - use per device work instead of global work to monitor device
> >> load. This enables suspend/resume of device devfreq and
> >> reduces monitoring code complexity.
> >> - decouple delayed work based load monitoring logic from core
> >> by introducing helpers functions to be used by governors. This
> >> provides flexibility for governors either to use delayed work
> >> based monitoring functions or to implement their own mechanism.
> >> - devfreq core interacts with governors via events to perform
> >> specific actions. These events include start/stop devfreq.
> >> This sets ground for adding suspend/resume events.
> >>
> >> The devfreq apis are not modified and are kept intact.
> >>
> >> Signed-off-by: Rajagopal Venkat <rajagopal.venkat@xxxxxxxxxx>
> >
> > Thank you!
> >
> >
> > Reviewed and Tested (at Exynos4210-Nuri).
> >
> > Acked-by: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
> >
>
> Rafael,
>
> Can this patchset be queued for v3.7?

No, but it can be queued for v3.8. I'll do that tomorrow, if time permits.

All non-fix things I'd had queued up for v3.7 were merged already.

Thanks,
Rafael


> >> ---
> >> Documentation/ABI/testing/sysfs-class-devfreq | 8 -
> >> drivers/devfreq/devfreq.c | 443 +++++++++++---------------
> >> drivers/devfreq/governor.h | 11 +
> >> drivers/devfreq/governor_performance.c | 16 +-
> >> drivers/devfreq/governor_powersave.c | 16 +-
> >> drivers/devfreq/governor_simpleondemand.c | 24 ++
> >> drivers/devfreq/governor_userspace.c | 23 +-
> >> include/linux/devfreq.h | 34 +-
> >> 8 files changed, 279 insertions(+), 296 deletions(-)
> >>
>
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/