Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

From: Viresh Kumar
Date: Wed Oct 10 2012 - 05:23:24 EST


On 10 October 2012 14:51, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
> We have spi, i2c and hsuart devices connected to the DMA controller.
> In case we would like to use DMA we have to have the dw_dmac loaded
> before them. Currently we have spi driver on subsys_initcall level,
> and Mika, who is developing it, will change to module_init_call level.
> However, it will just hide the potential issue. He also tried to use
> deferred module loading, but we don't know if it's good solution or
> not, and that solution requires something to stop deferring at some
> moment.
>
> Might be we missed something and there is a better solution.

My eyes aren't 6/6 now. I need specs now.
How could i miss that you just removed the very intentional subsys_init()
call. My bad.

I take my Acked-by: back :)

--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/