Re: [PATCH 1/6] x86, RAS: Add a barebones RAS subtree

[Borislav Petkov]

On Mon, Oct 08, 2012 at 04:53:46PM -0700, Tony Luck wrote:
> On Mon, Oct 8, 2012 at 10:11 AM, Borislav Petkov <bp@xxxxxxxxx> wrote:
> > +config X86_RAS
> > +       def_bool y
> > +       prompt "X86 RAS features"
> > +       ---help---
> > +       A collection of Reliability, Availability and Serviceability software
> > +       features which enable hardware error logging and reporting. Leave it
> > +       at 'y' unless you really know what you're doing.
> > +
> 
> The intent of "X86_RAS" is just to show/hide all the menu
> options for the individual features - which will all use
>           depends on X86_RAS
> right? Having this set to "y" doesn't actually enable any of
> the features - they all have their own CONFIG_* variables.
> 
> Perhaps we could make that clearer in the help text? And
> ditch the "Leave it at 'y' ... ", I don't think it helps anyone.

Good point. I've changed it to a simple bool which opens a submenu when
enabled (diff ontop):

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 85f666390b5e..d39c2fc20a81 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -688,12 +688,10 @@ config X86_CYCLONE_TIMER
        depends on X86_SUMMIT
 
 config X86_RAS
-       def_bool y
-       prompt "X86 RAS features"
+       bool "X86 RAS features"
        ---help---
        A collection of Reliability, Availability and Serviceability software
-       features which enable hardware error logging and reporting. Leave it
-       at 'y' unless you really know what you're doing.
+       features which enable hardware error logging and reporting.

The def_bool y intent was from earlier but it materialized in a patch
which I sent last week or so which makes CONFIG_X86_MCE enabled by
default so no need to enable those additional RAS stuff by default.

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/