RE: [remoteproc:for-next 6/9] remoteproc_virtio.c:(.text+0x238e7e):undefined reference to `vring_transport_features'

[Sjur BRENDELAND]

Hi Ohad,

> On Tue, Oct 2, 2012 at 10:24 AM, Ohad Ben-Cohen <ohad@xxxxxxxxxx>
> wrote:
> > On Mon, Oct 1, 2012 at 4:45 AM, Fengguang Wu
> <fengguang.wu@xxxxxxxxx> wrote:
> >> Hi Ohad,
> >>
> >> FYI, kernel build failed on
> >>
> >> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/ohad/remoteproc.git
> for-next
> >> head:   bec109a430e8c67bae1743f7e71898283234a77f
> >> commit: ec4d02d9180f407c41f8310a13b34e473c671fbb [6/9] remoteproc:
> Add STE modem driver
> >> config: i386-randconfig-b102 (attached as .config)
> >>
> >> It should be an old bug. The commit happen to be the one to trigger
> >> the errors because it selects CONFIG_EMOTEPROC.
> >
> > Thanks Fengguang.
> >
> > This should be fixed by a patch I pushed today to remoteproc's for-next
> branch.
> >
> > Though I wonder, Sjur, do we want to limit the architectures/platforms
> > where the STE modem driver can be selected on ? Is it ARM only perhaps ?
> 
> Can you please address the above question ?

Sorry for not responding sooner, but I thought this issue was solved with
your patch  "remoteproc: fix (again) the virtio-related build breakage"
(https://lkml.org/lkml/2012/10/6/85).

I'm not sure I understand why you would want to add a dependency to ARM.
But if you're uncomfortable by having STE_MODEM_RPROC directly selectable,
perhaps we could let it be selected by arch specific Kconfig files,  e.g. mach-ux500?

Regards,
Sjur

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/