Re: [PATCH 5/5] regulator: tps65090: add external control supportfor DCDC

From: Mark Brown
Date: Tue Oct 09 2012 - 03:04:08 EST


On Tue, Oct 09, 2012 at 11:51:19AM +0530, Laxman Dewangan wrote:
> On Tuesday 09 October 2012 11:58 AM, Mark Brown wrote:

> >There's support for GPIO driven enable lines in the framework already,
> >this driver should be able to use this happily, this sort of hardware is
> >exactly the use case it was written for.

> yes, I am using the gpio driven enable lines in the framework.
> This patch does the some configuration in register to enable external
> control and configure the regulator_config (fill gpio related stuff
> in config) before registering
> the regulator. There is no call of gpio libs from the driver.

The code seemed way more complex than that... did you notice the fact
that if a GPIO is specified then the register enable/disable control
will be ignored if provided?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/