Re: [PATCH 1/3] mfd: Convert tps6586x to irq_domain

From: Laxman Dewangan
Date: Tue Oct 09 2012 - 02:38:34 EST


On Tuesday 09 October 2012 11:53 AM, Mark Brown wrote:
On Tue, Oct 09, 2012 at 11:18:24AM +0530, Laxman Dewangan wrote:
On Tuesday 09 October 2012 11:36 AM, Mark Brown wrote:
but can you convert to regmap_irq?
Yes, the motivation was this when I started this cleanups but found
that there is 4 interrupt status and 5 interrupt mask register.
Probably we need to pass the number of interrupt status and
interrupt mask register to expand the regmap-irq framework to handle
this case also. If it is fine then I can work towards that.
Can you explain in more detail - I guess there's a different mapping of
the bits into the registers for mask and status (in which case the
generic code just won't work anyway).
The bit definitions are also different in status and mask register and yes, this will be again problem as we do in isr thread
data->status_buf[i] &= ~data->mask_buf[i];

So given the constraint, generic will not work here.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/