RE: Possible regression: BUG in fs/sysfs/group.c:65

From: Wei, Gang
Date: Tue Oct 09 2012 - 01:44:39 EST


Kent Yoder wrote on 2012-10-06:
> On Fri, Oct 05, 2012 at 11:16:06AM -0700, Eric W. Biederman wrote:
>> Ben Guthro <ben@xxxxxxxxxx> writes:
>>
>>> I am seeing a regression in today's (Oct 5) kernel - 2 WARNINGS, and a
>>> BUG below that seems to occur upon resuming from S3.
>>>
>>> I can start a bisection with 3.6 - but wanted to check to see if
>>> anyone else is also experiencing this failure...
>>
>> I took a quick look and this is a deterministic failure. The same
>> file is being added to sysfs twice.
>>
>> Since the routine causing this failure appears to be sys_add_ppi I
>> expect the commit that added this failure mode is the commit below.
>>
>> Xiaoyan Zhang, Kent Yoder can you guys look at this see why the tpm
>> code is adding itself multiple times into sysfs?
>
> It looks like the ppi sysfs teardown code is MIA. Xiaoyan, can you add
> it to tpm_ppi.c, with a caller in tpm_unregister_hardware?

I will try to provide a fix.

Jimmy

Attachment: smime.p7s
Description: S/MIME cryptographic signature