Re: [bisected] stray angle bracket in dmesg

From: Markus Trippelsdorf
Date: Mon Oct 08 2012 - 10:18:26 EST


On 2012.10.08 at 15:05 +0100, Wouter M. Koolen wrote:
> Hi guys,
>
> After upgrading from 3.5.4 to 3.5.5 I started noticing log lines of the
> form (just a random sample)
>
> pci_bus 0000:00: >resource 4 [io 0x0000-0x0cf7]
> pnp 00:07: >Plug and Play ACPI device, IDs PNP0303 (active)
> system 00:04: >[io 0x0680-0x069f] has been reserved
> pci_root PNP0A08:00: >host bridge window [io 0x0000-0x0cf7]
>
> Note the right angle bracket between the device name and the message
> string. These angle brackets were not there up till 3.5.4.
>
> This does not happen in all dmesg lines. Only the ones that start with a
> device identifier.
>
> I assume this angle bracket was not intentional. Otherwise please excuse
> the noise.
>
> I noticed this because all of these lines now suddenly slip through my
> logcheck ignore rules.
>
> Bisection points to this commit:
>
> commit 3d822616ca81881d8c19d0b473e79ba241c700de
> Author: Markus Trippelsdorf <markus@xxxxxxxxxxxxxxx>
> Date: Sat Aug 18 18:35:51 2012 -0600

This patch should be reverted for stable, since the move to ASCII SOH (
commit 04d2c8c83d0) wasn't backported. So the fix just isn't necessary.

--
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/