Re: [PATCH 2/2] remoteproc: remove the now-redundant kref

From: Ohad Ben-Cohen
Date: Sun Jul 15 2012 - 05:17:22 EST


On Sat, May 26, 2012 at 10:36 AM, Ohad Ben-Cohen <ohad@xxxxxxxxxx> wrote:
> Now that every rproc instance contains a device, we don't need a
> kref anymore to maintain the refcount of the rproc instances:
> that's what device are good with!
>
> This patch removes the now-redundant kref, and switches to
> {get, put}_device instead of kref_{get, put}.
>
> We also don't need the kref's release function anymore, and instead,
> we just utilize the class's release handler (which is now responsible
> for all memory de-allocations).
>
> Cc: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> Cc: Fernando Guzman Lugo <fernando.lugo@xxxxxx>
> Signed-off-by: Ohad Ben-Cohen <ohad@xxxxxxxxxx>
> ---
> drivers/remoteproc/remoteproc_core.c | 59 +++++++++++---------------------
> drivers/remoteproc/remoteproc_virtio.c | 8 ++--
> include/linux/remoteproc.h | 3 --
> 3 files changed, 24 insertions(+), 46 deletions(-)

Applied (after moving the kerneldoc for rproc_class_release() to the
patch where that function was introduced).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/