Re: [PATCH] remoteproc: allocate vrings on demand, free when not needed

From: Ohad Ben-Cohen
Date: Sun Jul 15 2012 - 05:10:46 EST


On Sun, May 20, 2012 at 3:00 PM, Ohad Ben-Cohen <ohad@xxxxxxxxxx> wrote:
> Dynamically allocate the vrings' DMA when the remote processor
> is about to be powered on (i.e. when ->find_vqs() is invoked),
> and release them as soon as it is powered off (i.e. when ->del_vqs()
> is invoked).
>
> The obvious and immediate benefit is better memory utilization, since
> memory for the vrings is now only allocated when the relevant remote
> processor is being used.
>
> Additionally, this approach also makes recovery of a (crashing)
> remote processor easier: one just needs to remove the relevant
> vdevs, and the entire vrings cleanup takes place automagically.
>
> Tested-by: Fernando Guzman Lugo <fernando.lugo@xxxxxx>
> Signed-off-by: Ohad Ben-Cohen <ohad@xxxxxxxxxx>
> ---
> drivers/remoteproc/remoteproc_core.c | 109 +++++++++++++++---------------
> drivers/remoteproc/remoteproc_internal.h | 2 +
> drivers/remoteproc/remoteproc_virtio.c | 13 +++-
> 3 files changed, 67 insertions(+), 57 deletions(-)

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/