Re: Small bug: Wrong return check from idr_pre_get in loop.c

[Jesper Juhl]

On Fri, 13 Jul 2012, Silva Paulo wrote:

> idr_pre_get never returns a value < 0. It returns 0 (no memory) or 1 (OK).
> 
Please read Documentation/SubmittingPatches

In summary:
 - you are missing a Signed-off-by: line.
 - there is no diffstat.
 - the patch is an attachment, not inline in the email.
 - the recipients list of the email could be improved (see below).

If you had used scripts/get_maintainer.pl on your patch you'd have gotten 
a better list of recipients for your patch mail:
  $ scripts/get_maintainer.pl My_linux-3.5-rc6_patches
  Jens Axboe <axboe@xxxxxxxxx> (commit_signer:15/17=88%)
  Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> (commit_signer:6/17=35%)
  Kay Sievers <kay.sievers@xxxxxxxx> (commit_signer:5/17=29%)
  Jeff Moyer <jmoyer@xxxxxxxxxx> (commit_signer:2/17=12%)
  Dmitry Monakhov <dmonakhov@xxxxxxxxxx> (commit_signer:2/17=12%)
  linux-kernel@xxxxxxxxxxxxxxx (open list)

Please try again.

-- 
Jesper Juhl <jj@xxxxxxxxxxxxx>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/