Re: [PATCH 2/3] ipc: allow compat IPC version field parsing if!ARCH_WANT_OLD_COMPAT_IPC

[Andrew Morton]

On Thu, 12 Jul 2012 09:47:56 +0100 Will Deacon <will.deacon@xxxxxxx> wrote:

> > >  static inline int compat_ipc_parse_version(int *cmd)
> > >  {
> > > -#ifdef CONFIG_ARCH_WANT_OLD_COMPAT_IPC
> > > +#ifdef	__ARCH_WANT_COMPAT_IPC_PARSE_VERSION
> > >  	int version = *cmd & IPC_64;
> > >  
> > >  	/* this is tricky: architectures that have support for the old
> > 
> > Could we do this purely in Kconfig?  Add a new
> > CONFIG_ARCH_WANT_COMPAT_IPC_PARSE_VERSION and always set it true if
> > CONFIG_ARCH_WANT_OLD_COMPAT_IPC?
> 
> That would also work, although the current approach mirrors what is done for
> the native case (i.e. this is the compat equivalent of
> __ARCH_WANT_IPC_PARSE_VERSION).
> 
> I'm not too fussed either way, so I can change it if you prefer?

It would be best to change both as a separate patch.

It's not a big deal: just a matter of consistency and use of up-to-date
idioms.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/