Re: [PATCH 1/2] gpio/omap: move bank->dbck initialization to omap_gpio_mod_init()

[DebBarma, Tarun Kanti]

On Wed, Jul 11, 2012 at 11:21 PM, Paul Walmsley <paul@xxxxxxxxx> wrote:
> On Wed, 11 Jul 2012, Tarun Kanti DebBarma wrote:
>
>> Since the bank->dbck initialization in a one time operation there
>> is no need to keep this within gpio_debounce(). Therefore, moving
>> clk_get(bank->dbck) to omap_gpio_mod_init(). Since the value of
>> bank->dbck would be NULL at the beginning, this check has been
>> removed.
>>
>> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@xxxxxx>
>> Reported-by: Paul Walmsley <paul@xxxxxxxxx>
>> Reviewed-by: Jon Hunter <jon-hunter@xxxxxx>
>> Cc: Kevin Hilman <khilman@xxxxxx>
>> Cc: Rajendra Nayak <rnayak@xxxxxx>
>> Cc: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
>> Cc: Cousson, Benoit <b-cousson@xxxxxx>
>> Cc: Paul Walmsley <paul@xxxxxxxxx>
>> ---
>>  drivers/gpio/gpio-omap.c |   10 ++++------
>>  1 files changed, 4 insertions(+), 6 deletions(-)
>
> Reviewed-by: Paul Walmsley <paul@xxxxxxxxx>
>
> These drivers are maintained by Grant Likely and Linus Walleij:
>
> GPIO SUBSYSTEM
> M:      Grant Likely <grant.likely@xxxxxxxxxxxx>
> M:      Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>
> S:      Maintained
> T:      git git://git.secretlab.ca/git/linux-2.6.git
> F:      Documentation/gpio.txt
> F:      drivers/gpio/
> F:      include/linux/gpio*
>
> So you'll want to cc them.  They are probably also who should merge these.
Ok, I wanted Kevin to have a look first. Anyways, I have cc'ed.
Thanks.
--
Tarun
>
>
> - Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/