Re: [PATCH] mm/hugetlb: split outis_hugetlb_entry_migration_or_hwpoison

[Mel Gorman]

On Mon, Jul 09, 2012 at 06:12:41PM +0800, Wanpeng Li wrote:
> From: Wanpeng Li <liwp@xxxxxxxxxxxxxxxxxx>
> 
> Code was duplicated in two functions, clean it up.
> 
> Signed-off-by: Wanpeng Li <liwp.linux@xxxxxxxxx>

is_hugetlb_entry_migration() now returns true for hwpoisoned pages. In
this block

                if (unlikely(is_hugetlb_entry_migration(entry))) {
                        migration_entry_wait(mm, (pmd_t *)ptep, address);
                        return 0;

we now will call migration_entry_wait and return 0 to the fault handler
instead of VM_FAULT_HWPOISON_LARGE | VM_FAULT_SET_HINDEX(h - hstates).
By co-incidence this might work because migration of hugetlb happens for
poisoned pages but it would be just a co-incidence. Some other change in
the future such as better support for memory hotplug of regions backed
by hugetlbfs may break it again.

Superficially, this patch looks broken and the changelog contains
no motivation as to why this patch should be merged such as being a
pre-requisite for another fix or feature.  It just looks like churn for
the sake of churn. It might be just me but it feels like I'm seeing a lot
more of this style of patch recently on linux-mm and review bandwidth is
not infinite :(

Nak.

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/