Re: [PATCH] kbuild: all{no,yes,mod,def,rand}config only read fileswhen instructed to.

From: Michal Marek
Date: Mon May 07 2012 - 14:59:07 EST


Dne 7.5.2012 14:37, Eric W. Biederman napsal(a):
>
> Prevent subtle surprises to both people working on the kconfig code
> and people using make allnoconfig allyesconfig allmoconfig and
> randconfig by only attempting to read a config file if
> KCONFIG_ALLCONFIG is set.
>
> Common sense suggests attempting to read the extra config files does
> not make sense unless requested. The documentation says the code
> won't attempt to read the extra config files unless requested.
> Current usage does not appear to include people depending on the code
> reading the config files without the variable being set

It's true that this bug/feature has been there since the introduction of
KCONFIG_ALLCONFIG, but I doubt anyone relies on it.


> So do the
> simple thing and stop reading config files when passed
> all{no,yes,mod,def,rand}config unless KCONFIG_ALLCONFIG environment
> variable is set.

Yes! I applied to kbuild.git#kconfig, with Reported-by: Stephen. Thanks
to both of you.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/