Re: [PATCH 1/2] x86, reboot: revert stop_other_cpus to using IRQwith NMI fallback

From: Ingo Molnar
Date: Mon May 07 2012 - 09:10:22 EST



* Don Zickus <dzickus@xxxxxxxxxx> wrote:

> The end result of this more
> complicated-looking-diff-than-it-really-is, is a patch that
> mostly reverts
>
> 3603a25 x86, reboot: Use NMI instead of REBOOT_VECTOR to stop cpus
>
> and instead just sticks another if-case after the REBOOT_IRQ
> and checks to see if online_cpus are still > 1, and if so,
> clobber the rest of the cpus with an NMI.

Ok, would be nice to shape this as a 'dumb' revert as-is, and do
the simple change in a separate patch, or so. That makes it
easier to review (and easier to debug, should it break).

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/