Re: [ALSA hda 3.4-rc] suspend2ram regression in snd_hda_intel

From: Konstantin Khlebnikov
Date: Sun May 06 2012 - 04:32:16 EST


Konstantin Khlebnikov wrote:
Mainline commit 785f857d1cb0856b612b46a0545b74aa2596e44a
("ALSA: hda - Set codec to D3 forcibly even if not used")
breaks sound for my notebook (thinkpad x220),
looks like codec cannot wake from power-save state after resume.
After reverting looks like all works fine.

how to reproduce:
* unplug the power cord (to enable hda power safe mode)
* play something and stop
* wait until the background noise disappears (codec went into power-save mode)
* suspend
* resume
* play something again and hear the silence
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Bump

BTW, I don't see any locks around hda power-save code, for example hda_power_work() reads
codec->power_on and codec->power_count without any locks. This seems racy.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/