[PATCH 8/8] kbuild: remove useless warning

From: Sam Ravnborg
Date: Sat May 05 2012 - 04:21:30 EST


From: Artem Bityutskiy <artem.bityutskiy@xxxxxxxxxxxxxxx>

This patch removes annoying warning:

Makefile:708: "WARNING: Appending $KCFLAGS (-Wno-sign-compare) from command line to kernel $CFLAGS"

which is printed every time I use KCFLAFS. The commit which introduced the
warning:

69ee0b3 kbuild: do not pick up CFLAGS from the environment

tells about the problems when people have CFLAGS in their environment,
then switches to KCFLAFS which should be enough to solve the issue, but
it anyway introduces a warning. I think it is too much and I find this
warning very annoying - why should we warn users when they use the
build system properly?

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@xxxxxxxxxxxxxxx>
Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
---
scripts/Kbuild.arch | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/scripts/Kbuild.arch b/scripts/Kbuild.arch
index 6ff27c6..7841825 100644
--- a/scripts/Kbuild.arch
+++ b/scripts/Kbuild.arch
@@ -127,20 +127,13 @@ KBUILD_CFLAGS += $(warning)
endif

# Add user supplied CPPFLAGS, AFLAGS and CFLAGS as the last assignments
-# But warn user when we do so
-warn-assign = \
-$(warning "WARNING: Appending $$K$(1) ($(K$(1))) from $(origin K$(1)) to kernel $$$(1)")
-
ifneq ($(KCPPFLAGS),)
- $(call warn-assign,CPPFLAGS)
KBUILD_CPPFLAGS += $(KCPPFLAGS)
endif
ifneq ($(KAFLAGS),)
- $(call warn-assign,AFLAGS)
KBUILD_AFLAGS += $(KAFLAGS)
endif
ifneq ($(KCFLAGS),)
- $(call warn-assign,CFLAGS)
KBUILD_CFLAGS += $(KCFLAGS)
endif

--
1.6.0.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/