Re: [PATCH] net: l2tp: unlock socket lock before returning from l2tp_ip_sendmsg

From: Sasha Levin
Date: Wed May 02 2012 - 09:50:03 EST


On Wed, May 2, 2012 at 3:28 PM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> Good catch, but please use existing code style in this function.
>
> rc = -EDESTADDRREQ;
> if (sk->sk_state != TCP_ESTABLISHED)
>        goto out;
>
> Also, please add in your commit message bug origin to ease stable team
> work (not counting reviewers work)
>
> Bug added in commit 2f16270f41e1 (l2tp: Fix locking in l2tp_ip.c)
>
> Really, given the amount of patches you already sent, you should already
> know that.
>
> Thanks
>
>

Understood. I'll resend.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/