Re: [PATCH v4 3/3] cred: change keyctl_session_to_parent() to use task_work_add()

From: David Howells
Date: Thu Apr 19 2012 - 12:52:47 EST


Oleg Nesterov <oleg@xxxxxxxxxx> wrote:

> +#define key_replace_session_keyring() do { } while (0)
> +

Ummm... Why? You've made the function no longer exist and so this shouldn't be
there anymore. You shouldn't just leave the call sites in place.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/