Re: [RFC 2/3] sched: add type checks to for_each_cpu_mask()
From: Linus Torvalds
Date: Sat Apr 14 2012 - 17:16:06 EST
On Sat, Apr 14, 2012 at 3:14 PM, Sasha Levin <levinsasha928@xxxxxxxxx> wrote:
> -#define for_each_cpu_mask(cpu, mask) \
> +#define for_each_cpu_mask(cpu, mask) \
> + typecheck(struct cpumask *, (mask)); \
> for ((cpu) = 0; (cpu) < 1; (cpu)++, (void)mask)
Stuff like this is *WRONG*.
You now totally broke
if (xyzzy)
for_each_cpu_mask() {
}
because you turned the loop into two separate statements.
If this is needed, it needs to be done right. You could have done it by doing
#define for_each_cpu_mask(cpu, mask) \
for (typecheck(struct cpumask *, (mask)), (cpu) = 0; (cpu) < 1; (cpu)++)
or similar (I think you can drop the (void)(mask) because the variable
is now used by the typecheck macro).
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/