Re: [PATCH] mfd: omap: Restore TLL initialization

[Munegowda, Keshava]

On Tue, Jun 28, 2011 at 3:34 AM, Kevin Hilman <khilman@xxxxxx> wrote:
> "Munegowda, Keshava" <keshava_mgowda@xxxxxx> writes:
>
>> On Fri, Jun 24, 2011 at 2:31 AM, Jassi Brar <jassisinghbrar@xxxxxxxxx> wrote:
>>> The commit
>>>  7e6502d577106fb5b202bbaac64c5f1b065 'mfd: Add omap-usbhs runtime PM support'
>>> besides moving to RPM, removes necessary TLL initialization as well.
>>>
>>> Restore the TLL initialization, without which device detection fails.
>>>
>>> Signed-off-by: Jassi Brar <jaswinder.singh@xxxxxxxxxx>
>
> [...]
>
>> if you move to RPM, you should'tn access these configuration/reset
>> registers in your driver.
>
> Yes, but Jaswinder's changelog clearly shows that the runtime PM (and
> thus hwmod) init is not doing the equivalent of what was removed from
> the driver.
>
> A hunch after a quick glance is that the driver changes are only doing
> runtime PM calls on the UHH device and not the TTL device.  In fact,
> the patch that builds the USB host omap_device[1] doesn't even build one.
>
>> moreover, the patch 'mfd: Add omap-usbhs runtime PM support' is
>> already reverted.
>
> It is reverted for this merge window, but will be added back for the
> next window, so Jaswinder's problem still needs to be fixed the right way.
>
> Please rework the USB host runtime PM conversion so that *all* the IP
> blocks are managed by runtime PM and the driver is doing runtime PM
> calls for all the devices used.
>
> Kevin
> [1] http://marc.info/?l=linux-omap&m=130693494126396&w=2
>

Ya, the changes are going on ; I will post the patches soon.
keshava
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/