Re: [PATCH] Bluetooth: Don't sleep after deleting command timer

From: Gustavo F. Padovan
Date: Tue Apr 26 2011 - 11:49:42 EST


Hi Imran,

* Imran Haider <imran1008@xxxxxxxxx> [2011-04-22 19:02:42 -0400]:

> This fix adds on to commit b77dcf84. It seems that scheduling a timeout
> of 250ms after deleting the command timer causes a kernel panic when
> system is resuming from Suspend-to-RAM. I tried adding another timeout
> before deleting the command timer but that didn't help so I believe that
> some code in hci_dev_do_close must execute after the command timer is
> deleted before control is returned to another thread.
>
> The only bit the command timer handler hci_cmd_timer() touches is HCI_RESET.
> It should be fine to delete the timer after testing the HCI_UP bit.
> ---
> net/bluetooth/hci_core.c | 9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)

I already have for that. But thanks anyway. ;)

--
Gustavo F. Padovan
http://profusion.mobi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/