Re: [PATCH v4 00/24] Introduce little endian bitops
From: Linus Torvalds
Date: Sun Jan 16 2011 - 21:51:36 EST
On Sun, Jan 16, 2011 at 6:37 PM, Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote:
>
> Changing *_bit_le() to take "void *" instead of "unsigned long *"
> makes this patch series acceptable?
That would seem to at least make all the filesystem code happier, and
they can continue to do just something like
#define ext2_set_bit __set_bit_le
(or whatever the exact sequence ends up being).
> Or do we also need to change *_bit_le() to handle unaligned address
> correctly? (i.e. not only long aligned address but also byte aligned
> address)
No, I don't think that is required. We've never done it before, and
we've never had the type-safety for the little-endian (aka "minix")
bitops historically. So I'd just keep the status quo.
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/