Re: [PATCH v2 1/2] tcm: Add support for BIDI-COMMANDS and XDWRITE_READ_10emulation

From: Boaz Harrosh
Date: Sun Sep 19 2010 - 09:35:22 EST


On 09/19/2010 03:29 PM, Boaz Harrosh wrote:
> On 09/16/2010 12:41 AM, Nicholas A. Bellinger wrote:
>> /* Fall through for DMA_TO_DEVICE */
>> case DMA_NONE:
>> CMD_TFO(cmd)->queue_status(cmd);
>> @@ -6347,6 +6460,23 @@ static inline void transport_free_pages(struct se_cmd *cmd)
>> kmem_cache_free(se_mem_cache, se_mem);
>> }
>>
>
> Again the request for an update tree. (Might be missing some code here)
>
> The above does a break; in bidi case, but are you freeing this here regardless?
>

Scratch this out stupid me. That's in another function. Rrrr I need my coffee now

Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/