Re: [PATCH 2/9] RapidIO, powerpc/85xx: modify RIO port-write interrupthandler
From: Micha Nelissen
Date: Mon Aug 16 2010 - 08:13:03 EST
Alexandre Bounine wrote:
- Rearranged RIO port-write interrupt handling to perform message buffering
as soon as possible.
I don't understand this comment: you still schedule work to read the
port-write queue; so how is this message buffering performed as soon as
possible?
- Modified to disable port-write controller when clearing Transaction Error (TE)
bit.
/* Schedule deferred processing if PW was received */
- if (ipwsr & RIO_IPWSR_QFI) {
+ if ((ipwmr & RIO_IPWMR_QFIE) && (ipwsr & RIO_IPWSR_QFI)) {
Why check the QFIE bit also?
+pw_done:
+ if (epwisr & 0x80000000) {
Magic value.
Micha
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/