Re: [PATCH 1/1] integer overflow issue in 'appletouch' driver

[Johannes Berg]

On Sat, 2010-08-07 at 14:00 +0000, Serge Belyshev wrote:
> Hi!
> 
> Since 2.6.34 the touchpad on my feb 2005 powerbook (mod. A1106) has
> stopped working. I've identified the following guilty patch:
> 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=04b4b88cca0ebe3813b4b6f014fb6a0db380b137
> 
> > ... Testing on one of such PowerBooks I have
> > noticed that touchpad always generates positive values, but some of
> > them are greater that 127, and thus, when cast to 'signed char' being
> > interpreted as a negative.
> 
> My device is 05ac:020e "fountain", actually generates *signed* values,
> thus the patch completely breaks it.

I think Ben might have the same issue. I guess we need per-touchpad
functions to read the data.

johannes


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/