Re: [PATCH 2/2] DMAENGINE: driver for the ARM PL080/PL081 PrimeCells

From: Linus Walleij
Date: Fri Aug 06 2010 - 18:55:14 EST


2010/8/6 Dan Williams <dan.j.williams@xxxxxxxxx>:

> One
> thing that should be on the todo list is to review the usage of memory
> barriers.  I don't think they are serving the purpose that you think
> they are.

All of those are from Peters original implementation, I never use any
barriers so they actually looked alien to me. Unless I get a clear
rationale from Peter I'll just remove them all for the time being in
the fix-up version due after updating to generic slave control.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/