Re: [PATCH] regulator: max8660 - fix a memory leak inmax8660_remove()

From: Mark Brown
Date: Fri Aug 06 2010 - 07:29:10 EST


On Fri, Aug 06, 2010 at 01:35:27PM +0800, Axel Lin wrote:
> In max8660_probe(), we allocate memory for max660.
> In max8660_remove(), current implementation only free rdev
> which is a member of struct max8660.
> Thus, there is a small memory leak when we unload the module.
>
> This patch fixes the memory leak by passing max660 to i2c clientdata,
> and properly kfree(max8660) in max8660_remove().
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>

Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/