Re: [PATCH 2/2] writeback: Adding pages_dirtied and pages_entered_writeback

From: Michael Rubin
Date: Fri Aug 06 2010 - 03:19:31 EST


On Thu, Aug 5, 2010 at 1:24 PM, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> Wait. These counters appear in /proc/vmstat. So why create standalone
> /proc/sys/vm files as well?

Andrew I was thinking about this today. And I think there is a case
for keeping the proc files.
Christoph was the one who pointed out to me that is their proper home
and I think he's right. Most if not all the tunables for writeback are
there. When one is trying to find the state of the system's writeback
activity that's the directory. Only having these variables in
/proc/vmstat to me feels like a way to make sure that users who would
need them won't find them unless they are reading source. And these
are folks who aren't reading source.

/proc/vmstat _does_ look like a good place to put the thresholds as it
already has similar values as the thresholds suck as
kswapd_low_wmark_hit_quickly.

mrubin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/