Re: [PATCH 42/42] drivers/media/video/bt8xx: Adjust confusing if indentation

[Luca Tettamanti]

Hi,
one minor comment:

On Thu, Aug 5, 2010 at 10:29 PM, Julia Lawall <julia@xxxxxxx> wrote:
> From: Julia Lawall <julia@xxxxxxx>
>
> Indent the branch of an if.
[...]
> diff --git a/drivers/media/video/bt8xx/bttv-i2c.c b/drivers/media/video/bt8xx/bttv-i2c.c
> index 685d659..695765c 100644
> --- a/drivers/media/video/bt8xx/bttv-i2c.c
> +++ b/drivers/media/video/bt8xx/bttv-i2c.c
> @@ -123,7 +123,7 @@ bttv_i2c_wait_done(struct bttv *btv)
> Â Â Â Âif (wait_event_interruptible_timeout(btv->i2c_queue,
> Â Â Â Â Â Â Â Âbtv->i2c_done, msecs_to_jiffies(85)) == -ERESTARTSYS)
>
> - Â Â Â rc = -EIO;
> + Â Â Â Â Â Â Â rc = -EIO;

I'd also remove the empty line before the indented statement, it's confusing...

Luca
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/