Re: [PATCH 1/2] usb gadget: don't save bind callback in structusb_gadget_driver

[MichaÅ Nazarewicz]

On Thu, 05 Aug 2010 11:39:54 +0200, Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:

> On Thu, Aug 05, 2010 at 10:58:52AM +0200, MichaÅ Nazarewicz wrote:
> > On Mon, 02 Aug 2010 20:27:45 +0200, Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> > > diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c
> > > @@ -2045,7 +2045,6 @@ static void __exit udc_exit(void)
> > >  }
> > > EXPORT_SYMBOL(usb_gadget_unregister_driver);
> > > -EXPORT_SYMBOL(usb_gadget_register_driver);
> >
> > *IF* you are going to send an updated patch, how about removing
> > empty line above this EXPORT_SYMBOL().

> I kept that, because the '}' doesn't belong to
> usb_gadget_unregister_driver.

In that case disregard my last comment. Move along, nothing to see. ;)

--
Best regards,                                        _     _
| Humble Liege of Serenely Enlightened Majesty of  o' \,=./ `o
| Computer Science,  MichaÅ "mina86" Nazarewicz       (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/