Re: [PATCH v2 2/3] genhd, efi: add efi partition metadata to hd_structs

From: Kay Sievers
Date: Wed Aug 04 2010 - 11:29:11 EST


On Wed, Aug 4, 2010 at 16:44, Will Drewry <wad@xxxxxxxxxxxx> wrote:
> On Wed, Aug 4, 2010 at 5:14 AM, Kay Sievers <kay.sievers@xxxxxxxx> wrote:

>> But the only thing we are really interested in is the UUID, which,
>> like Tejun already suggested, we should probably store
>> format-independent, and have it always accessible. That way, we would
>> not need any type-specific parser, we just handle the normal DCE
>> format.
>
> I'll bump it out and make it the efi code generic-ify its uuid. ÂOut
> of curiousity, were you and Tejun thinking of keeping it as a 36 byte
> string or as the 16 byte packed value. ÂWhile less space efficient,
> I'd prefer the u8[36] as it avoids dealing with versioning when
> parsing the user-supplied string. ÂInstead, each partition type can
> properly unparse its uuids according to what they expect.

I think we should use the packed version, which is case-insensitive,
or at least normalize it to a defined case.

Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/