Re: [PATCH v2 1/3] block, partition: add partition_meta_info to hd_struct

[Will Drewry]

On Wed, Aug 4, 2010 at 2:57 AM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> Hello,
>
> On 08/04/2010 04:04 AM, Will Drewry wrote:
>> This changes adds a partition_meta_info struct which itself contains a
>> union of structures that provide partition table specific metadata.
>>
>> This change leaves the union empty. The subsequent patch includes an
>> implementation for CONFIG_EFI_PARTITION-based metadata.
>>
>> Signed-off-by: Will Drewry <wad@xxxxxxxxxxxx>
>
> Generally looks good to me.
>
>>  /*
>>   * add_gd_partition adds a partitions details to the devices partition
>>   * description.
>> @@ -12,6 +13,7 @@ struct parsed_partitions {
>>               sector_t from;
>>               sector_t size;
>>               int flags;
>> +             struct partition_meta_info *info;
>>       } parts[DISK_MAX_PARTS];
>
> But you can just embed the structure here.  It's a temp data structure
> to make things easier for individual partition scan code.  There's no
> need to save bytes.

Great - that'll simplify the code more.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/