RE: [PATCH 1/3 v2] media: Add a cached version of the contiguous videobuffers

From: Pawel Osciak
Date: Wed Aug 04 2010 - 03:57:08 EST


Hi Richard,

>Richard RÃjfors wrote:
>This patch adds another init functions in the videobuf-dma-contig
>which is named _cached in the end. It creates a buffer factory
>which allocates buffers using kmalloc and the buffers are cached.
>

Before I review this in more detail, could you elaborate more on
this? How large are your buffers, can kmalloc really allocate them
for you? I am not convinced how this is supposed to work reliably,
especially in a long-running systems.

Best regards
--
Pawel Osciak
Linux Platform Group
Samsung Poland R&D Center





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/