Re: oops in ioapic_write_entry

[Dave Airlie]

On Wed, Aug 4, 2010 at 7:38 AM, Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote:
> Yinghai Lu <yinghai@xxxxxxxxxx> writes:
>
>> On 08/03/2010 04:08 AM, Eric W. Biederman wrote:
>>>
>>> For the common case I think we still do the right thing, even now, for
>>> these broken bios tables.  There is likely an uncommon case for which
>>> something like your shared_legacy_irq deserves to be used, especially
>>> at it preserves our well tested historical behavior.
>>
>> Dave, Irnna, Gary:
>>
>> can you check this patch on your systems?
>
>
>
>>
>> Thanks
>>
>> Yinghai
>>
>> [PATCH] x86: check if apic/pin is shared with legacy one
>>
>> fix system that external device that have io apic on apic0/pin(0-15)
>
> Nacked-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
>
> Your patch addresses what appears to be a theoretical issue, caused by
> a BIOS bug.  So far you have not presented a credible scenario where
> this would affect anything in real life except the user visible irq
> number.
>
> Will you please stop, think, and describe what is going on clearly
> and how you expect this patch to affect anything, and please stop
> selling this patch as the solution to all of the world's ills.  You
> are being sloppy and wasting everyone's time.
>
> This patch definitely does not solve Dave Airlie's problem.  That was
> clearly caused by a (ACPI being disabled compared to the test case)
> and a bad BIOS provided MP table with an invalid apic_id, and our
> attempt to lookup the ioapic and failed.

Oh wow, I totally missed I had ACPI off on this build, I turned it off
a few kernels back to test the build didn't break, and forgot to turn
it back on.

So clearly my mptable is just busted and we can probably move along,
I'll rebuild/boot with ACPI now, and I think you can assume it works
fine unless I get back to you.

Thanks, and sorry for wasting time.

Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/