Re: [PATCH v2 RFC] efi: add and expose efi_partition_by_guid

[Will Drewry]

On Tue, Aug 3, 2010 at 1:50 PM, Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
> On Mon,  2 Aug 2010 21:52:46 -0500 Will Drewry wrote:
>
>
>> v2: pr_debug(KERN_WARNING -> pr_debug(. joe@xxxxxxxxxxx
>>     moved down trailing {. davem@xxxxxxxxxxxxx
>
> Eh?  see below.
>
>> ---
>>  fs/partitions/efi.c |   61 +++++++++++++++++++++++++++++++++++++++++++++++++++
>>  include/linux/efi.h |    5 ++++
>>  2 files changed, 66 insertions(+), 0 deletions(-)
>>
>> diff --git a/fs/partitions/efi.c b/fs/partitions/efi.c
>> index 9efb2cf..8669c4f 100644
>> --- a/fs/partitions/efi.c
>> +++ b/fs/partitions/efi.c
>> @@ -633,3 +633,64 @@ int efi_partition(struct parsed_partitions *state)
>>       printk("\n");
>>       return 1;
>>  }
>> +
>> +/**
>> + * efi_partition_by_guid
>> + * @bdev:    Whole block device to scan for a GPT.
>> + * @guid:    Unique identifier for the partition to find.
>> + *
>> + * N.b., returns on the first match since it should be unique.
>> + *
>> + * Returns:
>> + * -1 if an error occurred
>> + *  0 if there was no match (or not GPT)
>> + *  >=1 is the index of the partition found.
>> + *
>> + */
>> +int efi_partition_by_guid(struct block_device *bdev, efi_guid_t *guid) {
>
> That opening brace should be on a line by itself:
>
> int efi_partition_by_guid(struct block_device *bdev, efi_guid_t *guid)
> {

Thanks - yeah I failed to git commit --amend properly on the second posting :/

> and the kernel-doc function description should be like so:
>
> /**
>  * efi_partition_by_guid - find the first (only) matching guid on a block device
>
> or some such short function description.

I'll be sure to use the proper format on the next patch round!

thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/