RE: Additional fix : (was [v2]printk: fix delayed messages from CPUhotplug events)

From: Shilimkar, Santosh
Date: Tue Aug 03 2010 - 12:54:33 EST


> -----Original Message-----
> From: Randy Dunlap [mailto:rdunlap@xxxxxxxxxxxx]
> Sent: Tuesday, August 03, 2010 8:55 PM
> To: Shilimkar, Santosh
> Cc: Andrew Morton; Kevin Cernekee; linux-kernel@xxxxxxxxxxxxxxx; Russell
> King - ARM Linux
> Subject: Re: Additional fix : (was [v2]printk: fix delayed messages from
> CPU hotplug events)
>
> On Tue, 3 Aug 2010 13:03:25 +0530 Shilimkar, Santosh wrote:
>

<snip>

> > /**
> > + * console_cpu_notify - print deferred console messages after CPU
> hotplug
> > + *
> > + * If printk() is called from a CPU that is not online yet, the
> messages
> > + * will be spooled but will not show up on the console. This function
> is
> > + * called when a new CPU comes online and ensures that any such output
> > + * gets printed.
> > + */
> > +static int __cpuinit console_cpu_notify(struct notifier_block *self,
> > + unsigned long action, void *hcpu)
> > +{
>
>
> kernel-doc notation should include function parameters also, please.
>
Sure. Here is an updated version.
--------------------------------------------