Re: [PATCH] tc6393xb: fix wrong goto labels for error handling

From: Ian Molton
Date: Tue Aug 03 2010 - 09:46:09 EST


Acked-by: Ian Molton <ian.molton@xxxxxxxxxxxxxx>

On 3 August 2010 04:10, Axel Lin <axel.lin@xxxxxxxxx> wrote:
> This patch corrects the error handling path.
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
> ---
>  drivers/mfd/tc6393xb.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/tc6393xb.c b/drivers/mfd/tc6393xb.c
> index fcf9068..ef6c42c 100644
> --- a/drivers/mfd/tc6393xb.c
> +++ b/drivers/mfd/tc6393xb.c
> @@ -732,9 +732,9 @@ err_gpio_add:
>        if (tc6393xb->gpio.base != -1)
>                temp = gpiochip_remove(&tc6393xb->gpio);
>        tcpd->disable(dev);
> -err_clk_enable:
> -       clk_disable(tc6393xb->clk);
>  err_enable:
> +       clk_disable(tc6393xb->clk);
> +err_clk_enable:
>        iounmap(tc6393xb->scr);
>  err_ioremap:
>        release_resource(&tc6393xb->rscr);
> --
> 1.5.4.3
>
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/