Re: [PATCH -v3 2/2] x86: more early console output from compressed/misc.c

From: H. Peter Anvin
Date: Mon Aug 02 2010 - 18:47:22 EST


First, I'm not quite sure which 1/2 patch you're expecting this to be
compiled against.

On 08/02/2010 03:30 PM, Yinghai Lu wrote:
>
> + if (debug) {
> + putstr("decompress_kernel:\n");
> + printf(" input: [0x%lx-0x%lx], output: 0x%lx, heap: [0x%lx-0x%lx]\n",
> + (unsigned long)input_data,
> + (unsigned long)input_data + input_len - 1,
> + (unsigned long)output,
> + (unsigned long)heap,
> + (unsigned long)heap + BOOT_HEAP_SIZE - 1);
> + }
> +

This seems to be the only user of printf() in the code. As such, I
really suspect it's not worth pulling in all of printf(). I'd be
willing to be convinced, but if so I need (a) a concrete usage case, and
(b) it should be a separate patch.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/