Re: 6175ddf06b6172046a329e3abfd9c901a43efd2e breaks matroxfb console

From: H. Peter Anvin
Date: Mon Aug 02 2010 - 17:05:24 EST


On 08/02/2010 12:49 PM, Ondrej Zary wrote:
> Hello,
> matroxfb (at least with Mystique and Mystique 220) stopped working in 2.6.34 -
> the screen is completely corrupted. Bisection shows that
> 6175ddf06b6172046a329e3abfd9c901a43efd2e is first bad commit.
>
> Reverting 6175ddf06b6172046a329e3abfd9c901a43efd2e in 2.6.34 fixes the problem
> (1c5b9069e12e20d2fe883076ae0bf73966492108 must be reverted first).
>

Sounds like another driver which used memcpy_toio() when it should have
used iowrite32_rep() or __iowrite32_copy().

Hmm... is __iowrite32_copy() and iowrite32_rep() redundant? If so, we
should get rid of the former.

-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/