Re: [PATCH 1/2] x86, setup: reorgize the early_console_setup

[Thiago Farina]

On Mon, Aug 2, 2010 at 4:13 AM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> Index: linux-2.6/arch/x86/boot/string.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/boot/string.c
> +++ linux-2.6/arch/x86/boot/string.c
> @@ -12,7 +12,21 @@
> Â* Very basic string functions
> Â*/
>
> -#include "boot.h"
> +static inline int isdigit(int ch)
> +{
> + Â Â Â return (ch >= '0') && (ch <= '9');
> +}
> +
> +static inline int isxdigit(int ch)
> +{
> + Â Â Â if (isdigit(ch))
> + Â Â Â Â Â Â Â return true;
> +
> + Â Â Â if ((ch >= 'a') && (ch <= 'f'))
> + Â Â Â Â Â Â Â return true;
> +
> + Â Â Â return (ch >= 'A') && (ch <= 'F');
> +}
>

These to functions above can be fairly simplified by writting as:

static bool inline is_hex_digit(int c) {
  return (c >= '0' && c <= '9') ||
            (c >= 'A' && c <= 'F') ||
            (c >= 'a' && c <= 'f');
}

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/