Re: [PATCHv5 1/3] USB: gadget: composite: Better string overridehandling

[MichaÅ Nazarewicz]

On Sun, 01 Aug 2010 21:05:33 +0200, David Brownell <david-b@xxxxxxxxxxx> wrote:
> NAK.  You're still hard-wiring an un-managed serial number.

Uh?  I'm not.  Current code overrides the serial number only when the
iSerial module parameter is given:

+	if (iSerialNumber)
+		cdev->serial_override =
+			override_id(cdev, &cdev->desc.iSerialNumber);

and when host requests string which ID is saved as a overridden for
serial number the module parameter is taken.

+	else if (cdev->serial_override == id)
+		str = iSerialNumber;

--
Best regards,                                        _     _
| Humble Liege of Serenely Enlightened Majesty of  o' \,=./ `o
| Computer Science,  MichaÅ "mina86" Nazarewicz       (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/