Re: [PATCH 11/19] perf record: Release resources at exit

[Ingo Molnar]

* Nick Piggin <npiggin@xxxxxxx> wrote:

> On Sun, Aug 01, 2010 at 10:08:46PM -0300, Arnaldo Carvalho de Melo wrote:
> > From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> > 
> > So that we can reduce the noise on valgrind when looking for memory
> > leaks.
> 
> Really? That's rather crappy of valgrind. exit is well defined to release 
> resources and that's often a more efficient way to do it It finds and 
> batches things a lot better, eg. it can avoid all TLB flushing of freeing 
> memory that munmap requires.

That's certainly true but there's no valgrind crappiness here: valgrind simply 
can do a better job of finding leaks if there's a well defined "all resources 
the app still knows about are freed now" point.

The _kernel_ obviously can release all resources. The distinction is between 
'resources known to the app' and 'all resources'. That set contains the 
leaking resources.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/