Re: [PATCH 5/9] PM: suspend_block: Add debugfs file
Date: Sun Apr 25 2010 - 20:00:48 EST
On Sun, Apr 25, 2010 at 12:53:01PM -0700, Randy Dunlap wrote:
> > It's debug-like information, and has more than one value per file, so
> > debugfs seems like the proper place for it. I have no objection to it
> > going there.
> I have no objection if it really is debug info, but I'm not convinced
> of that yet.
Well, I'll note right now we have a somewhat annoying gap. If you
need to export multiple values such that they are consistent with each
other, what's the choice? /proc, where some (but not all) kernel
developers will say, "eeeeeeviilllll". /sys is explicitly for single
value per files only. And then we have /debugfs, where some pendants
are kvetching about whether something is "really" debug information.
One of the things that we sometimes have to tell people who are trying
to navigate the maze of upstream submission is that sometimes you need
to know who to ignore, and that sometimes rules are guidelines
(despite pendants who will NACK based on rules like, "/proc,
eeeeewwww", or "/debugfs must only strictly be for debug information".
Telling embedded developers who only want to submit their driver that
they must create a whole new pseudo-filesystem just to export a single
file that in older, simpler times, would have just been thrown into
/proc is really not fair, and is precisely the sort of thing that may
cause them to say, "f*ck it, these is one too many flaming hoops to
jump through". If we throw up too many barriers, in the long run it's
not actually doing Linux a service.
Sure, we need to make sure is code doesn't become a future burden, but
does a new file in /proc or something that might not _really_ be debug
information showing up in /debugfs really such a terrible thing in
terms of making the kernel less maintainable in the future?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/