Re: [PATCH RFC] PPC-BRIQ_PANEL: Remove BKL and replace with atomicvariable.
From: Thomas Gleixner
Date: Mon Oct 19 2009 - 01:04:45 EST
B1;2005;0cOn Sun, 18 Oct 2009, John Kacur wrote:
> >From b64c7d0f11eab96cb253b23c7264c999746116c0 Mon Sep 17 00:00:00 2001
> From: John Kacur <jkacur@xxxxxxxxxx>
> Date: Sun, 18 Oct 2009 21:29:21 +0200
> Subject: [PATCH] PPC-BRIQ_PANEL: Remove BKL and replace with atomic variable.
> There are no locks here except the bkl in briq_panel_open. It's only
> purpose is to ensure single access. Remove the bkl and ensure single access
> by making vfd_is_open an atomic_variable.
And again, can you please look more carefully at the init
vs. read/write functions ?
The BKL is not only protecting the single user variable it's also
serializing write against the access to the display in init.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/