Re: [PATCH V5 1/2] introduce ALS sysfs class

From: Zhang Rui
Date: Mon Aug 31 2009 - 04:51:14 EST


On Mon, 2009-08-31 at 16:34 +0800, Pavel Machek wrote:
> Hi!
>
> > @@ -0,0 +1,32 @@
> > +What: /sys/class/als/als[0-N]/desc
> > +Date: Aug. 2009
> > +KernelVersion: 2.6.32
> > +Contact: Zhang Rui <rui.zhang@xxxxxxxxx>
> > +Description: Strings which descibes the current Ambient Light Sensor
> > + device. This is given by native ALS driver as part of
> > + registration. e.g: "acpi_als" for ACPI ALS devices.
> > + RO
>
> Normal way to do that (backlight class does it, for example) is to
> have acpi_als instead of als0, and get rid of desc field.

IMO, both are okay, hard to say which is preferred.
Other sysfs classes like scsi_host, hwmon, input use this as well.
and you don't have a really strong objection to this, right? :)

thanks,
rui

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/