Re: [PATCH] m68k: avoid pgprot_noncached redefinition

[Geert Uytterhoeven]

On Thu, Aug 27, 2009 at 13:41, Heiko Carstens<heiko.carstens@xxxxxxxxxx> wrote:
> From: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
>
> While compiling m68k with defconfig I get tons if these warnings:
>
> /home2/heicarst/linux-2.6/arch/m68k/include/asm/pgtable_mm.h:148:1: warning: "pgprot_noncached" redefined
> In file included from /home2/heicarst/linux-2.6/arch/m68k/include/asm/pgtable_mm.h:138,
> Âfrom /home2/heicarst/linux-2.6/arch/m68k/include/asm/pgtable.h:4,
> Âfrom include/linux/mm.h:38,
> Âfrom /home2/heicarst/linux-2.6/arch/m68k/include/asm/atarihw.h:134,
> Âfrom arch/m68k/atari/debug.c:20:
> include/asm-generic/pgtable.h:133:1: warning: this is the location of the previous definition
>
> Reason for this is that asm-generic/pgtable.h gets included in pgtable_mm.h
> before pgprot_noncached gets defined.
> So the check "#ifndef pgprot_noncached" in the generic header file is too early.
> Solve this by including the generic header file after the arch define.

Thanks, but Linus has just pulled the fix last night.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/