Re: [PATCH] DRM_RADEON should not select FB stuff
From: Dave Airlie
Date: Tue Jul 14 2009 - 19:31:57 EST
On Wed, Jul 15, 2009 at 8:28 AM, Mikael Pettersson<mikpe@xxxxxxxx> wrote:
> Commit 771fe6b912fca54f03e8a72eb63058b582775362 changed the DRM_RADEON
> Kconfig entry to select a bunch of framebuffer options. However, the
> driver doesn't actually use any of those things, so these selects are
> bogus. This patch reverts them.
>
> I'm running this right now. drm and radeon loaded, acceleration works,
> nothing anywhere is complaining about missing the FB stuff.
NAK, the code is only enabled under staging at the moment but it will use these.
Dave.
>
> Signed-off-by: Mikael Pettersson <mikpe@xxxxxxxx>
>
> diff -rupN linux-2.6.31-rc3/drivers/gpu/drm/Kconfig linux-2.6.31-rc3.radeon-dont-select-fb-dammit/drivers/gpu/drm/Kconfig
> --- linux-2.6.31-rc3/drivers/gpu/drm/Kconfig 2009-07-14 13:42:51.000000000 +0200
> +++ linux-2.6.31-rc3.radeon-dont-select-fb-dammit/drivers/gpu/drm/Kconfig 2009-07-14 14:03:03.000000000 +0200
> @@ -44,11 +44,6 @@ config DRM_R128
> config DRM_RADEON
> tristate "ATI Radeon"
> depends on DRM && PCI
> - select FB_CFB_FILLRECT
> - select FB_CFB_COPYAREA
> - select FB_CFB_IMAGEBLIT
> - select FB
> - select FRAMEBUFFER_CONSOLE if !EMBEDDED
> help
> Choose this option if you have an ATI Radeon graphics card. There
> are both PCI and AGP versions. You don't need to choose this to
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/